Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit feedback #141

Merged
merged 15 commits into from
Oct 26, 2023
Merged

Audit feedback #141

merged 15 commits into from
Oct 26, 2023

Conversation

cristovaoth
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6651418815

  • 28 of 29 (96.55%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 99.02%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/core/Modifier.sol 11 12 91.67%
Totals Coverage Status
Change from base Build 6454388651: 1.2%
Covered Lines: 121
Relevant Lines: 122
💛 - Coveralls

@cristovaoth cristovaoth merged commit 83acaa1 into eip-712-signatures Oct 26, 2023
2 checks passed
@cristovaoth cristovaoth deleted the audit-feedback branch October 26, 2023 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristovaoth @auryn-macmillan